sam
/
nsxiv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
nsxiv/etc/woodpecker/clang-tidy-checks

17 lines
635 B
Plaintext
Raw Normal View History

[ci]: use cppcheck and clang-tidy for static analysis
2022-06-15 06:55:16 +01:00
# checks
clang-analyzer-*,clang-diagnostic-*,bugprone-*,performance-*,modernize-*
add support for multi-frame images via imlib2 (#373) this will be a massive change compared to the usual stuff. however the gains will be worth it: * we gain lots of additional animated image support. * and we'll gain _even_ more format support as imlib2 adds them, without needing any change in our code-base. * about ~300 LoC will be purged once we remove our internal gif and webp loader. as for when to remove the internal loaders, a good time might be when debian upgrades their imlib2, currently it seems to be at v1.7.5, which doesn't support animated images. as of now, nsxiv will continue to build with the internal gif/webp loaders (assuming they were enabled in config.mk) if imlib2 version is below 1.8.0 and will print out a deprecation notice. and if imlib2 version supports multi-frame then it will simply ignore the internal loaders and use the imlib2 one. in other words, users shouldn't need to do anything on their side. everything that previously functioned will continue to function regardless of the user's imlib2 version (though they might see the annoying deprecation notice if the imlib2 version doesn't support multi-frame images). known issue: * image loading performance can be noticeably worse in imlib2 versions below 1.9.0 Closes: https://codeberg.org/nsxiv/nsxiv/issues/301 Closes: https://codeberg.org/nsxiv/nsxiv/issues/300 Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/373 Reviewed-by: TAAPArthur <taaparthur@noreply.codeberg.org>
2023-01-08 10:02:56 +00:00
misc-*,android-cloexec-*,llvm-include-order
[ci]: disable noisy checks (#365) * disable `cert-err33-c` and `readability-identifier-length` check which causes warnings on clang-tidy v14. * disable all "readability" checks by default, instead just opt-into the useful ones (such as duplicate include). Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/365 Reviewed-by: Berke Kocaoğlu <berke.kocaoglu@metu.edu.tr>
2022-09-05 02:47:32 +01:00
-readability-*,readability-duplicate-include,readability-misleading-indentation
[ci]: use cppcheck and clang-tidy for static analysis
2022-06-15 06:55:16 +01:00
# silence
-misc-unused-parameters
-bugprone-easily-swappable-parameters,-bugprone-narrowing-conversions,-bugprone-incorrect-roundings
-bugprone-implicit-widening-of-multiplication-result,-bugprone-integer-division
[ci]: disable noisy checks (#365) * disable `cert-err33-c` and `readability-identifier-length` check which causes warnings on clang-tidy v14. * disable all "readability" checks by default, instead just opt-into the useful ones (such as duplicate include). Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/365 Reviewed-by: Berke Kocaoğlu <berke.kocaoglu@metu.edu.tr>
2022-09-05 02:47:32 +01:00
-android-cloexec-fopen,-android-cloexec-pipe,-cert-err33-c
[ci]: make it easy to run analysis locally (#395) allows for developers to more easily run the analysis locally before opening a pull request if they wish. also disables a noisy warning (bugprone-assignment-in-if-condition) producing too many false positives. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/395 Reviewed-by: Berke Kocaoğlu <kberke@metu.edu.tr> Co-authored-by: NRK <nrk@disroot.org> Co-committed-by: NRK <nrk@disroot.org>
2022-12-02 10:50:15 +00:00
-bugprone-assignment-in-if-condition
[ci]: silence false positive warning clang-tidy currently flags the following: util.c:57:8: error: 'ptr' may be set to null if 'realloc' fails, which may result in a leak of the original buffer [bugprone-suspicious-realloc-usage,-warnings-as-errors] ptr = realloc(ptr, size); the analysis here is correct, but if realloc fails, we simply exit so there's no real "leak". moreover this check is not very useful for nsxiv's codebase because we do not use naked realloc(), instead we use the erealloc wrapper that exits on failure. so just disable the warning entirely instead of changing the source code to silence the false positive.
2023-05-13 18:28:27 +01:00
-bugprone-suspicious-realloc-usage
[ci]: use cppcheck and clang-tidy for static analysis
2022-06-15 06:55:16 +01:00
# false positive warnings
-clang-analyzer-valist.Uninitialized
-misc-no-recursion